code review

1. Review code in public (each owner provide smell code)2. Analyze code issue  2.1 Let owner to analyze in turn  2.2 Encourage members to give suggestion or analyze code issue3. Document good ideas or pattern

- Style guide & code example for newer- Less smell code - Have the sense of writing high quality code- Good comment- Enhance code ability

Team 1

- unit test  basic to improve

1. No time? Teach & Give more time to study2. Complain? Let member explain & code healthy3. No owner? get support from other teams。give benefit 4. Monitor owner? team members

Team 3

owner

member2

support

6 - 7(1.5 month)

problem

- Submit code early & everyday- Avoid huge code lines for each submit (recommend maximum 150 code line)- Comment require: What change is being made and why it was made - submit guide - gerrit( support) ? - header: short summary - an imperative sentence - body: why & background & extra info

- Discuss issue/problem from owner- Share knowledge (basic &  skill)- Document  good practice and add style guilde- Invite Smax teams to join & more feekback or practice- everyweek

- Code review meeting to discuss code issue (optinal) - everyweek   - Document (good practice & different idea)   - Collect all feedback   - Share knowledge-  Join group-  Lead member to study style guide - Review each submit  - Review everyday or frequently  - be fast  - Make comments for team members which optimize it in free time & track it  - Overview comment: Courtesy & Explain Why & Giving Guidance- Review design for each feature

Team 2

member1

Duty

duty

https://google.github.io/eng-practices/review/reviewer/standard.html

- Give owner more effect- Each team should follow it

Achievement

1. Vote quality of code (reward for winner team )   - Per month to per week.2. Vote good comment (reward for winner team or person)  - Per month to per week

Second

First

All Teams

Code Review